Feat/metrics controller #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZKS-60 Metrics controller
Implement Metrics defined in Notion tech-design doc. And make them retrieve mock data |
0xkenj1
requested changes
Jul 15, 2024
0xyaco
reviewed
Jul 17, 2024
apps/api/test/metrics.e2e-spec.ts
Outdated
Comment on lines
19
to
21
| afterAll(async () => { | ||
| await app.close(); | ||
| }); |
There was a problem hiding this comment.
Is there any performance reason, or something like that, for this not to be an afterEach?
0xkenj1
requested changes
Jul 18, 2024
| @@ -3,10 +3,11 @@ import { ProvidersModule } from "@packages/providers"; | |||
|
|
|||
| import { ApiController } from "./api.controller"; | |||
| import { RequestLoggerMiddleware } from "./common/middleware/request.middleware"; | |||
| import { MetricsController } from "./metrics/metrics.controller"; | |||
|
|
|||
There was a problem hiding this comment.
on this .module you say we add the Natspec due to the consumer applied? because in general .module doesn't have anything to be documented
0xkenj1
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Linear
Closes ZKS-60 ZKS-61
Description
Adds Metrics controller with eps:
Both return mocked data